One more thing...
Prasanna Kumar Kalever <prasanna.kale...@redhat.com> writes:
> this patch adds 'GlusterServer' related schema in qapi/block-core.json
>
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com>
> ---
> block/gluster.c | 115
> +++++++++++++++++++++++++++++----------------------
> qapi/block-core.json | 68 +++++++++++++++++++++++++++---
> 2 files changed, 128 insertions(+), 55 deletions(-)
>
> diff --git a/block/gluster.c b/block/gluster.c
> index 8a54ad4..c4ca59e 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
[...]
> @@ -628,7 +641,9 @@ static int qemu_gluster_create(const char *filename,
> }
> out:
> g_free(tmp);
> - qemu_gluster_gconf_free(gconf);
> + if (gconf) {
> + qapi_free_BlockdevOptionsGluster(gconf);
> + }
qapi_free_FOO(NULL) is safe. Let's drop the conditional. Could be done
on commit, or as a follow-up cleanup.
> if (glfs) {
> glfs_fini(glfs);
> }
[...]
R-by stands.
