On 27/07/16 9:51 am, "Michael S. Tsirkin" <m...@redhat.com> wrote:
>On Mon, Jul 25, 2016 at 02:27:18PM +0400, Marc-André Lureau wrote:
>> Hi
>>
>> On Mon, Jul 25, 2016 at 10:41 AM, Prerna <saxenap....@gmail.com> wrote:
>> >
>> >
>> > On Thu, Jul 7, 2016 at 12:04 PM, Prerna Saxena <saxenap....@gmail.com>
>> > wrote:
>> >>
>> >> From: Prerna Saxena <prerna.sax...@nutanix.com>
>> >>
>> >> The current vhost-user protocol requires the client to send responses to
>> >> only a
>> >> few commands. For the remaining commands, it is impossible for QEMU to
>> >> know the
>> >> status of the requested operation -- ie, did it succeed? If so, by what
>> >> time?
>> >>
>> >> This is inconvenient, and can also lead to races. As an example:
>> >> [..snip..]
>> >>
>> >> References:
>> >> v1 : https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg07152.html
>> >> v2 : https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00048.html
>> >>
>> >>
>> >> Prerna Saxena (2):
>> >> vhost-user: Introduce a new protocol feature REPLY_ACK.
>> >> vhost-user: Attempt to fix a race with set_mem_table.
>> >>
>> >> docs/specs/vhost-user.txt | 44 +++++++++++++++
>> >> hw/virtio/vhost-user.c | 133
>> >> ++++++++++++++++++++++++++++++----------------
>> >> 2 files changed, 130 insertions(+), 47 deletions(-)
>> >>
>> >
>> > Ping !
>> > Michael, MarcAndre, Did you have a chance to look at this patch series?
>> >
>>
>> That's not going to make it in 2.7 I am afraid.
>
>It's a bugfix so - depends on how quickly can comments be addressed.
>
>--
>MST
Thanks Michael, Marc,
I just posted a v4 addressing the review comments. Both make-check and
compilation run to completion.
Marc,
I addressed part of your suggestion on documentation. However, I have been
reminded in the past about being more verbose while describing the change :
<https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg07428.html>
Hope this patch series is in time for 2.7 :-)
Regards,
Prerna
