On 28/07/2016 16:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Similarly to other chr_close callbacks, free char type specific data. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > qemu-char.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/qemu-char.c b/qemu-char.c > index 6ed6dd6..e276485 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -786,6 +786,14 @@ static GSource *mux_chr_add_watch(CharDriverState *s, > GIOCondition cond) > return d->drv->chr_add_watch(d->drv, cond); > } > > +static void mux_chr_close(struct CharDriverState *chr) > +{ > + MuxDriver *d = chr->opaque; > + > + /* is more cleanup needed? */
Perhaps qemu_chr_free(d->drv)? Paolo > + g_free(d); > +} > + > static CharDriverState *qemu_chr_open_mux(const char *id, > ChardevBackend *backend, > ChardevReturn *ret, Error **errp) > @@ -810,6 +818,7 @@ static CharDriverState *qemu_chr_open_mux(const char *id, > chr->opaque = d; > d->drv = drv; > d->focus = -1; > + chr->chr_close = mux_chr_close; > chr->chr_write = mux_chr_write; > chr->chr_update_read_handler = mux_chr_update_read_handler; > chr->chr_accept_input = mux_chr_accept_input; >