On 08/01/2016 01:04 AM, Fam Zheng wrote:
Currently "make docker-test-mingw@fedora" has a warning like:
/tmp/qemu-test/src/block/curl.c: In function 'curl_sock_cb':
/tmp/qemu-test/src/block/curl.c:172:6: warning: format '%d' expects
argument of type 'int', but argument 4 has type 'curl_socket_t {aka long
long unsigned int}'
DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
^
cc1: all warnings being treated as errors
Cast to int to suppress it.
Signed-off-by: Fam Zheng <f...@redhat.com>
---
block/curl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/curl.c b/block/curl.c
index da9f5e8..426fb4d 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -169,7 +169,7 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int
action,
state->sock_fd = fd;
s = state->s;
- DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
+ DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd);
switch (action) {
case CURL_POLL_IN:
aio_set_fd_handler(s->aio_context, fd, false,
Is curl_socket_t always of type long long unsigned int? why not use %llu ?
(...Yeah, I know, we're probably not going to be dealing with FDs above
2-4 billion, just curious...)
--js
Benefit of doubt (this cast is almost certain to never do the wrong
thing, and even if it did, it's just a dprintf)
Reviewed-by: John Snow <js...@redhat.com>