On Fri, 30 Jul 2010 11:34:57 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> Miguel Di Ciurcio Filho <miguel.fi...@gmail.com> writes: > > > This patch address two issues. > > > > 1) When savevm is run using an previously saved snapshot id or name, it will > > delete the original and create a new one, using the same id and name and not > > prompting the user of what just happened. > > > > This behaviour is not good, IMHO. > > Debatable. Automatically destroying previously saved data without any notice seems a quite bad behavior to me. > > We add a '-f' parameter to savevm, to really force that to happen, in case > > the > > user really wants to. > > Incompatible change, looks like it'll break libvirt. Doesn't mean we > can't do it ever, but right now may not be the best time. Perhaps after > savevm & friends are fully functional in QMP. Chris, could you please check whether this impacts libvirt?