On Tue, Aug 09, 2016 at 02:43:41PM +0200, Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Replace the old manual dispatch and validation code by the generic one > > provided by qapi common code. > > > > Note that it is now possible to call the following commands that used to > > be disabled by compile-time conditionals: > > - dump-skeys > > - query-spice > > - rtc-reset-reinjection > > - query-gic-capabilities > > > > Their fallback functions return an appropriate "feature disabled" error. > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > Means query-qmp-schema no longer shows whether these commands are > supported, doesn't it? > > Eric, could this create difficulties for libvirt or other introspection > users?
Libvirt doesn't use query-qmp-schema at all - we just blindly invoke the commands and catch error. That said I agree with your point though. It seems pretty undesirable for query-qmp-schema to report that the commands exist when they clearly don't really exist in any usable manner. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
