On Wed, Aug 10, 2016 at 3:12 AM, Dr. David Alan Gilbert <dgilb...@redhat.com> wrote: > * Lai Jiangshan (jiangshan...@gmail.com) wrote: >> The feature vm-template makes the containers(VMs) can >> be started in 130ms and save 80M memory for every >> container(VM). So that the hyper containers are fast >> and high-density as normal containers. > > Very nice.
Hello, David, thank you for your review. >> >> 4) yet-another-post-copy-migration >> It is a possible feature, no toolkit can do it well now. >> Using nbd server/client on the memory file is reluctantly Ok but >> inconvenient. A special feature for tmpfs might be needed to >> fully complete this feature. >> No one need yet another post copy migration method, >> but it is possible when some crazy man need it. > > Well as the crazy man who wrote the current postcopy code, what would > you need it to do that the current one can't? I don't think we need to add a new post-copy-migration method. I mentioned it for showing one of the potentials of this patch. > > I can't see anything noticeably wrong with your code; but I see the bot > gave you some style warnings. Fixed in v2. Thanks, Lai > > Dave > >> Signed-off-by: Lai Jiangshan <jiangshan...@gmail.com> >> --- >> exec.c | 5 +++++ >> include/exec/cpu-common.h | 1 + >> include/migration/migration.h | 1 + >> migration/migration.c | 9 +++++++++ >> migration/ram.c | 37 ++++++++++++++++++++++++++++--------- >> qapi-schema.json | 6 +++++- >> qmp-commands.hx | 3 +++ >> 7 files changed, 52 insertions(+), 10 deletions(-)
