Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

[Paolo Bonzini]

On 11/08/2016 11:36, Lv Zheng wrote:
>  
> -    error_setg(errp, "'-acpitable' requires one of 'data' or 'file'");
> +    val = qemu_opt_get((QemuOpts *)opts, "fadt");
> +    if (val) {
> +        unsigned long rev;

Don't use qemu_opt_get.  Add the field to AcpiTableOptions in
qapi-schema.json, and then use hdrs->has_fadt, hdrs->fadt.

Paolo