On 17.08.2016 [10:20:26 -0700], Nish Aravamudan wrote: > On 17.08.2016 [13:12:19 -0000], Chris J Arges wrote: > > Can you rebase your fix on 1:2.5+dfsg-5ubuntu10.4 (due to the > > regression fix mentioned in #25)? > > Will do!
Done. > > Another thing about your backport is that it dropped the qem2 bits > > from the patch. Is there a reason for this? If so please mention it in > > the debian/patch file. > > Ah yes, those sections of the upstream fix do not apply cleanly due to > differing context (not even present). The latest update includes the relevant context... > That does bring up another question, though: > > @smkbot or anyone else that might know. It seems the original series was > 4 patches > (http://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg06037.html), > and there was a follow-on of 7 patches that fixed a regression in that > series > (http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05424.html). > Do we need to backport all 11 patches? In the first series, at least, > there is mention that patch 1/4 fixes an issue for reading VHD images. > While I realize that this particular bug is just for creating/converting > images, would it also be appropriate to backport the full set of fixes > for VHD/VPC? On my own review, I believe we want to backport the 1 and 3 patch from the first series, so that qemu-img is self-consistent, in terms of reading and writing the new 'qem2' images. The second series does include fixes, but not related to this bug, so if we were to include them in a SRU, I'd rather they come in from a related bug report. @Stephen or anyone else affected, I've submitted an updated build at https://launchpad.net/~nacc/+archive/ubuntu/lp1490611 for qemu 1:2.5+dfsg-5ubuntu10.5~ppa1 which should include the relevant. Please test once it has finished building. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid Status in QEMU: Fix Released Status in qemu package in Ubuntu: Fix Released Status in qemu source package in Xenial: In Progress Bug description: [Impact] * Starting with a raw disk image, using "qemu-img convert" to convert from raw to VHD results in the output VHD file's virtual size being aligned to the nearest 516096 bytes (16 heads x 63 sectors per head x 512 bytes per sector), instead of preserving the input file's size as the output VHD's virtual disk size. * Microsoft Azure requires that disk images (VHDs) submitted for upload have virtual sizes aligned to a megabyte boundary. (Ex. 4096MB, 4097MB, 4098MB, etc. are OK, 4096.5MB is rejected with an error.) This is reflected in Microsoft's documentation: https://azure.microsoft.com /en-us/documentation/articles/virtual-machines-linux-create-upload- vhd-generic/ * The fix for this bug is a backport from upstream. http://git.qemu.org/?p=qemu.git;a=commitdiff;h=fb9245c2610932d33ce14 [Test Case] * This is reproducible with the following set of commands (including the Azure command line tools from https://github.com/Azure/azure- xplat-cli). For the following example, I used qemu version 2.2.1: $ dd if=/dev/zero of=source-disk.img bs=1M count=4096 $ stat source-disk.img File: ‘source-disk.img’ Size: 4294967296 Blocks: 798656 IO Block: 4096 regular file Device: fc01h/64513d Inode: 13247963 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 1000/ smkent) Gid: ( 1000/ smkent) Access: 2015-08-18 09:48:02.613988480 -0700 Modify: 2015-08-18 09:48:02.825985646 -0700 Change: 2015-08-18 09:48:02.825985646 -0700 Birth: - $ qemu-img convert -f raw -o subformat=fixed -O vpc source-disk.img dest-disk.vhd $ stat dest-disk.vhd File: ‘dest-disk.vhd’ Size: 4296499712 Blocks: 535216 IO Block: 4096 regular file Device: fc01h/64513d Inode: 13247964 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 1000/ smkent) Gid: ( 1000/ smkent) Access: 2015-08-18 09:50:22.252077624 -0700 Modify: 2015-08-18 09:49:24.424868868 -0700 Change: 2015-08-18 09:49:24.424868868 -0700 Birth: - $ azure vm image create testimage1 dest-disk.vhd -o linux -l "West US" info: Executing command vm image create + Retrieving storage accounts info: VHD size : 4097 MB info: Uploading 4195800.5 KB Requested:100.0% Completed:100.0% Running: 0 Time: 1m 0s Speed: 6744 KB/s info: https://[redacted].blob.core.windows.net/vm-images/dest-disk.vhd was uploaded successfully error: The VHD https://[redacted].blob.core.windows.net/vm-images/dest-disk.vhd has an unsupported virtual size of 4296499200 bytes. The size must be a whole number (in MBs). info: Error information has been recorded to /home/smkent/.azure/azure.err error: vm image create command failed * A fixed qemu-img will not result in an error during azure image creation. It will require passing -o force_size, which will leverage the backported functionality. [Regression Potential] * The upstream fix introduces a qemu-img option (-o force_size) which is unset by default. The regression potential is very low, as a result. ... I also ran the above commands using qemu 2.4.0, which resulted in the same error as the conversion behavior is the same. However, qemu 2.1.1 and earlier (including qemu 2.0.0 installed by Ubuntu 14.04) does not pad the virtual disk size during conversion. Using qemu-img convert from qemu versions <=2.1.1 results in a VHD that is exactly the size of the raw input file plus 512 bytes (for the VHD footer). Those qemu versions do not attempt to realign the disk. As a result, Azure accepts VHD files created using those versions of qemu-img convert for upload. Is there a reason why newer qemu realigns the converted VHD file? It would be useful if an option were added to disable this feature, as current versions of qemu cannot be used to create VHD files for Azure using Microsoft's official instructions. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1490611/+subscriptions
