On Wed, Aug 17, 2016 at 07:37:16PM -0700, no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Message-id: 1471487270-1490-1-git-send-email-programmingk...@gmail.com > Subject: [Qemu-devel] [PATCH v5 0/4] ADB improvements > Type: series > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/1471487270-1490-1-git-send-email-programmingk...@gmail.com -> > patchew/1471487270-1490-1-git-send-email-programmingk...@gmail.com > Switched to a new branch 'test' > 8e862cb adb.c: prevent NO_KEY value from going to guest > 649cccc adb.c: correct several key assignments > f4950b2 adb.c: add support for QKeyCode > db1d3d7 adb-keys.h: initial commit > > === OUTPUT BEGIN === > Checking PATCH 1/4: adb-keys.h: initial commit... > ERROR: line over 90 characters > #30: FILE: include/hw/input/adb-keys.h:14: > + * Additional information: > http://www.archive.org/stream/apple-guide-macintosh-family-hardware/Apple_Guide_to_the_Macintosh_Family_Hardware_2e#page/n345/mode/2up
This error can be ignored - the line is only long because of the stupidly long URL, which should not be broken. > total: 1 errors, 0 warnings, 141 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 2/4: adb.c: add support for QKeyCode... > Checking PATCH 3/4: adb.c: correct several key assignments... > Checking PATCH 4/4: adb.c: prevent NO_KEY value from going to guest... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
