Dear Stefan, Stefan Weil <s...@weilnetz.de> writes:
> On 08/23/16 21:00, Sascha Silbe wrote: >> Stefan Weil <s...@weilnetz.de> writes: >> >>> Commit 50455700092412d90ffaf57ee5d00f38f7d1cc5b added new code which >>> does not compile for Windows. >> [...] >> This worked fine in my cross-build environment (mingw32-* on Fedora 22) >> as that has glib 2.44.0. Is there a specific reason you're using a glib >> version that's at least half a decade old (glib 2.30.0 was released in >> 2011) on Windows? AFAICT the MSYS2 installer recommended by glib >> upstream [1] has glib 2.41.1. > > My Debian build machine has glib 2.28.8 for cross compilation, obviously > unchanged since 2011, so it is indeed half a decade old. OK, so it's just your local build environment being outdated? No particular need to use that ancient version? > On my Debian notebook I use a cross glib 2.46.2, so cross compilation > will work there without that patch. > > That greatly reduces the need for the patch. Glad to hear. It would be possibly to support the combination of glib < 2.30.0 AND windows, but only by copying a considerable amount of code from glib. I'd prefer to avoid that if we can help it. >> As for your change: It may fix building qemu itself, but building >> test-logging should still be broken. Unlike some other tests, it isn't >> built on POSIX or Linux only. Did "make check" work before my patch in >> your environment? > > "make check" for Windows does not work in my cross environment. OK, I see. Sascha -- Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg https://se-silbe.de/ USt-IdNr. DE281696641
