On 23 August 2016 at 07:50, Peter Lieven <p...@kamp.de> wrote: > Am 16.08.2016 um 18:30 schrieb Daniel P. Berrange: >> >> In previous commit >> >> commit c7628bff4138ce906a3620d12e0820c1cf6c140d >> Author: Gerd Hoffmann <kra...@redhat.com> >> Date: Fri Oct 30 12:10:09 2015 +0100 >> >> vnc: only alloc server surface with clients connected >> >> the VNC server was changed so that the 'vd->server' pixman >> image was only allocated when a client is connected. >> >> Since then if a client disconnects and then reconnects to >> the VNC server all they will see is a black screen until >> they do something that triggers a refresh. On a graphical >> desktop this is not often noticed since there's many things >> going on which cause a refresh. On a plain text console it >> is really obvious since nothing refreshes frequently. >> >> The problem is that the VNC server didn't update the guest >> dirty bitmap, so still believes its server image is in sync >> with the guest contents. >> >> To fix this we must explicitly mark the entire guest desktop >> as dirty after re-creating the server surface. Move this >> logic into vnc_update_server_surface() so it is guaranteed >> to be call in all code paths that re-create the surface >> instead of only in vnc_dpy_switch() >> >> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > > I noticed that these patches is as well not in master yet and therefore > not included in the 2.7.0-rc4 tagged yesterday.
Dan, Gerd -- we're going to need an rc5 anyway -- can you comment on whether this patch is "should be in rc5" material? (If it is I can commit it to master directly.) thanks -- PMM
