On 30 August 2016 at 15:14, Eric Blake <ebl...@redhat.com> wrote: > On 08/29/2016 11:10 PM, Gonglei wrote: >> gnutls commit 846753877d renamed LIBGNUTLS_VERSION_NUMBER to >> GNUTLS_VERSION_NUMBER. >> If using gnutls before that verion, we'll get the below warning: > > s/verion/version/ > >> crypto/tlscredsx509.c:618:5: warning: "GNUTLS_VERSION_NUMBER" is not defined >> > > The C preprocessor is well-defined to treat an unknown macro name as 0. > Which compiler are you using that complains? Is this something that we > consistently work around, or is it better to figure out how to fix your > compiler to quit complaining?
This is gcc's -Wundef, which we explicitly enable in configure. (The rationale is the usual one, ie that almost all the time this happens it's by accident and so it's worth putting in the extra effort to avoid the odd case where you were doing it deliberately.) thanks -- PMM
