On Wed, Aug 11, 2010 at 01:55:02PM +0530, Prerna Saxena wrote: > This patch adds few more trace events for tracking IO and also to trace > balloon event flagged via the monitor. > > Signed-off-by: Prerna Saxena <pre...@linux.vnet.ibm.com> > ---
Thanks for adding these trace events. Two minor requests: 1. Please split the patch into one patch that adds ioport tracing and one that adds virtio-balloon tracing. If there is discussion related to one of these subsystems any follow up will be cleaner and only affect that commit. > diff --git a/trace-events b/trace-events > index 80197b6..cade0b5 100644 > --- a/trace-events > +++ b/trace-events > @@ -59,3 +59,11 @@ virtio_blk_handle_write(void *req, unsigned long sector, > unsigned long nsectors) > > # posix-aio-compat.c > paio_submit(void *acb, void *opaque, unsigned long sector_num, unsigned long > nb_sectors, unsigned long type) "acb %p opaque %p sector_num %lu nb_sectors > %lu type %lu" > + > +# ioport.c > +cpu_in(unsigned int addr, unsigned int val) "Addr %u Value %u" > +cpu_out(unsigned int addr, unsigned int val) "Addr %u Value %u" > + > +# balloon.c > +# Since requests are raised via monitor, not many tracepoints are needed. > +balloon_event(void *opaque, unsigned long addr) "Opaque %p Addr %lu" 2. Please follow the lowercase format string convention. All other trace events use lowercase "like %p this %u". Thanks, Stefan
