On Thu, 12 Aug 2010, Blue Swirl wrote: > > +static inline void read_physical(uint64_t addr, unsigned long size, void > > *val) > > +{ > > + return cpu_physical_memory_rw((target_phys_addr_t)addr, val, size, 0); > > +} > > + > > +static inline void write_physical(uint64_t addr, unsigned long size, void > > *val) > > +{ > > + return cpu_physical_memory_rw((target_phys_addr_t)addr, val, size, 1); > > +} > > Useless redirection? >
I guess we can just use cpu_physical_memory_read/write instead of read_physical and write_physical here. Ok also to all the other comments.