Am 16.09.2016 um 18:17 hat John Snow geschrieben: > > > On 09/15/2016 07:42 PM, John Snow wrote: > >Bypass the usual check to see if we are "allowed" to flush via the > >block model, and manually flush the BDS nodes themselves instead. > > > >This allows us to do things like migrate when we have a device with > >an open tray, but has a node that may need to be flushed. > > > >Specifically, this allows us to migrate when we have a CDROM with > >an open tray. > > > > How about: > > Reimplement bdrv_flush_all for vm_stop. In contrast to blk_flush_all, > bdrv_flush_all does not have device model restrictions. This allows > us to flush and halt unconditionally without error. > > This allows us to do things like migrate when we have a device with > an open tray, but has a node that may need to be flushed
I'd add: , or nodes that aren't currently attached to any device and need to be flushed. > Specifically, this allows us to migrate when we have a CDROM with > an open tray. Looks good otherwise. Kevin