On Tue, Sep 20, 2016 at 01:25:06PM -0500, Eric Blake wrote: > On 09/19/2016 02:42 PM, Eduardo Habkost wrote: > > Add a new optional field to query-cpu-definitions schema: > > "unavailable-features". It will contain a list of QOM properties > > that prevent the CPU model from running in the current host. > > > > Cc: David Hildenbrand <d...@linux.vnet.ibm.com> > > Cc: Michael Mueller <m...@linux.vnet.ibm.com> > > Cc: Christian Borntraeger <borntrae...@de.ibm.com> > > Cc: Cornelia Huck <cornelia.h...@de.ibm.com> > > Cc: Jiri Denemark <jdene...@redhat.com> > > Cc: libvir-l...@redhat.com > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > --- > > > +++ b/qapi-schema.json > > @@ -3111,10 +3111,31 @@ > > # QEMU version, machine type, machine options and accelerator > > options. > > # A static model is always migration-safe. (since 2.8) > > # > > +# @unavailable-features: #optional List of properties that prevent > > +# the CPU model from running in the current > > +# host. (since 2.7) > > We've missed 2.7; this should probably be 2.8. Otherwise reads okay to me; > > Reviewed-by: Eric Blake <ebl...@redhat.com>
Oops! I will fix it before merging. Thanks for spotting! -- Eduardo
