On 09/20/2016 07:34 PM, Peter Maydell wrote: > On 19 September 2016 at 20:54, Jakub Jermář <ja...@jermar.eu> wrote: >> >> * Do not assume memsz is already initialized in integratorcm_init >> * Calculate memsz directly from MachineState >> * Get rid of the now unused memsz property >> >> Signed-off-by: Jakub Jermar <ja...@jermar.eu> > > Thanks for this patch; this is definitely a bug but I think > this is not the best way to fix it. > > What we should do is add a realize function to the IntegratorCM > device, and move the code that depends on the value of memsz > from the init function to the realize function. That way the > device doesn't have to know anything about the machine.
Thanks, I will be sending a reworked patch shortly. Jakub
