On 26/09/2016 18:35, Andreas Färber wrote: > Am 26.09.2016 um 18:24 schrieb Paolo Bonzini: >> On 26/09/2016 18:20, Andreas Färber wrote: >>> Am 26.09.2016 um 18:17 schrieb Richard Henderson: >>>> On 09/26/2016 05:20 AM, Paolo Bonzini wrote: >>>>> On 26/09/2016 12:56, Sagar Karandikar wrote: >>>>>> -cpu-qom.h merged into cpu.h >>>>> >>>>> Please follow the model of other targets. RISCVCPUClass and the >>>>> RISCVCPU typedef should be in cpu-qom.h. > > After discussion with Paolo, the key word here is typedef. It doesn't > make sense to have the struct RISCVCPU in cpu-qom.h (the old approach) > but it makes perfect sense to have struct RISCVCPUClass and typedef > RISCVCPU in a separate cpu-qom.h.
Thanks Andreas, and sorry Sagar for the back-and-forth! Paolo