On 09/27/2016 02:56 PM, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> At the moment if you use a VMSTATE_*_EQUAL macro and the value doesn't match you just get an error about the section that failed e.g. qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' qemu-system-ppc64: load of migration failed: Invalid argument with this pair you get the field and the mismatched values. e.g. qemu-system-ppc64: 8000600FE1FF7AE1 != 8000600FE1FF3A21 qemu-system-ppc64: Failed to load cpu:env.insns_flags qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' qemu-system-ppc64: load of migration failed: Invalid argument which is much more likely to point you at the culprit. (Broken out from a larger vmstatification series, the only change since then is the values are printed in hex except for the le case). Dave Dr. David Alan Gilbert (2): migration: report an error giving the failed field migration: Report values for comparisons migration/vmstate.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
I see this as a strict improvement; though I don't know if there will be complaints about printing error messages instead of adding pathways for the Error object.
Meh. Existing errors here simply use error_report anyway, so: Reviewed-by: John Snow <js...@redhat.com>