On Tue, Sep 27, 2016 at 06:35:41PM +0000, Felipe Franciosi wrote: > > > On 27 Sep 2016, at 18:23, Daniel P. Berrange <berra...@redhat.com> wrote: > > > > On Tue, Sep 27, 2016 at 09:49:18AM -0700, Felipe Franciosi wrote: > >> > >> Signed-off-by: Felipe Franciosi <fel...@nutanix.com> > >> --- > >> io/channel-socket.c | 11 ++++++----- > >> io/channel-tls.c | 4 ++-- > >> io/channel-websock.c | 4 ++-- > >> io/channel.c | 10 ++++------ > >> migration/qemu-file-channel.c | 3 +-- > >> qemu-char.c | 3 +-- > >> 6 files changed, 16 insertions(+), 19 deletions(-) > > > > The test/test-io-channel-*.c unit tests should be updated to > > validate the correct handling. > > Hi Daniel, > > Actually it looks like all tests are using the has_feature() wrapper > already, so I'm not sure I need to fix anything here. Please let me > know if I missed something.
If we had full test coverage of the feature flags, then we should have seen a test failure for this bug. So there must be something we're not exercising in the test suite. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
