On Fri, Sep 30, 2016 at 11:21:35PM +0530, Akanksha Srivastava wrote: > Subject: [Qemu-devel] [PATCH] usb: Change *_exitfn return type from void to > int
This should read "from int to void", I guess. > The *_exitfn functions cannot fail and should not be > returning int. > Suggested as a Bite-sized task > Signed-off-by: Akanksha Srivastava <akanksha....@gmail.com> > --- > hw/usb/ccid-card-emulated.c | 4 ++-- > hw/usb/ccid-card-passthru.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) [...] > -static int passthru_exitfn(CCIDCardState *base) > +static void passthru_exitfn(CCIDCardState *base) > { > - return 0; > + return; > } Have you compile-tested this change? I think you'll have to adjust the definition of exitfn in CCIDCardClass, and ccid_card_exitfn (in hw/usb/dev-smartcard-reader.c) as well. Regards, Jonathan Neuschäfer
signature.asc
Description: PGP signature