On Mon, Oct 03, 2016 at 05:10:48PM +0100, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2016 at 04:25:40PM +0800, Gonglei wrote: > > diff --git a/backends/cryptodev.c b/backends/cryptodev.c > > new file mode 100644 > > index 0000000..a15904b > > --- /dev/null > > +++ b/backends/cryptodev.c > > @@ -0,0 +1,175 @@ > > +/* > > + * QEMU Crypto Device Implement > > s/Implement/Implementation/ > > > diff --git a/include/sysemu/cryptodev.h b/include/sysemu/cryptodev.h > > new file mode 100644 > > index 0000000..cc3c3be > > --- /dev/null > > +++ b/include/sysemu/cryptodev.h > > @@ -0,0 +1,145 @@ > > +/* > > + * QEMU Crypto Device Implement > > s/Implement/Implementation/ > > > + * > > + * Copyright (c) 2016 HUAWEI TECHNOLOGIES CO., LTD. > > + * > > + * Authors: > > + * Gonglei <arei.gong...@huawei.com> > > + * > > + * This library is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2 of the License, or (at your option) any later version. > > + * > > + * This library is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with this library; if not, see > > <http://www.gnu.org/licenses/>. > > + * > > + */ > > +#ifndef QCRYPTO_CRYPTODEV_H > > +#define QCRYPTO_CRYPTODEV_H > > + > > +#include "qom/object.h" > > +#include "qemu-common.h" > > + > > +/** > > + * QCryptoCryptoDevBackend: > > + * > > + * The QCryptoCryptoDevBackend object is an interface > > + * for different cryptodev backends, which provides crypto > > + * operation wrapper. > > I suggest calling it CryptoDevBackend since that's shorter and doesn't > repeat any information. I'm not sure why "QCrypto" is necessary.
I suggested that naming when we had it under the crypto/ directory, since that's the standard for code there. We've moved this into the backends/ directory now, so we don't need that name prefix anymore. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
