On Tue, Oct 4, 2016 at 5:34 PM Rafael David Tinoco < rafael.tin...@canonical.com> wrote:
> True. > > What about having a single config parameter as a place to put all vhost > logs for all drives for a single instance ? Remove the memfd implementation > with all the memfd shared_memory option ? Replace it with a > open+unlink+ftruncate+mmap approach only. > > I fail to see your point, memfd is superior to open+unlink and has other advantages with sealing etc. Regarding shared log, see my previous reply to Daniel. This way every device would get its own log file and vhost-user backends > would be able to get its file descriptors. (and, of course, allow the > security drivers to do their jobs). > > >> On Oct 04, 2016, at 10:25, Daniel P. Berrange <berra...@redhat.com> > wrote: > >> > >> Hmm, is there a reason why it is shared? That seems to make an > assumption > >> that all vhost-user backends would be managed by the same external > process. > >> While that may be the common case today, it doesn't feel like a > reasonable > >> assumption to make long term. IOW it feels wiser to have it set per-NIC > >> unless I'm missing something important that means it must be shared ? > > > > -- Marc-André Lureau
