On Sun, Aug 22, 2010 at 04:38:36PM -0500, Anthony Liguori wrote:
> On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
> >+linetoh_nop()
> >+{
> >+ local name args
> >+ name=$(get_name "$1")
> >+ args=$(get_args "$1")
> >+
> >+ # Define an empty function for the trace event
> >+ cat<<EOF
> >+static inline void trace_$name($args)
> >+{
> >+}
>
> This seems like it can potentially create a single header that ends
> up needed to know about every type of structure QEMU implements, no?
> If so, this would be challenging for improving modularity.
>
> Or would we restrict trace points to not allow passing of anything
> but void *s?
Trace events use void *. It would be nicer to use the specific struct
pointer type but that is not possible for the reason you mentioned.
Stefan
