On Mon, Oct 03, 2016 at 20:42:43 +0100, Alex Bennée wrote: > > Richard Henderson <r...@twiddle.net> writes: > > > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > > Handle both endian-ness, and sizes up to 8. > > Handle expanding non-atomically, when emulating in serial. > > > > Signed-off-by: Richard Henderson <r...@twiddle.net> > > --- > <snip> > > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > > index 291d50b..65e3663 100644 > > --- a/tcg/tcg-op.c > > +++ b/tcg/tcg-op.c > <snip> > > +void tcg_gen_atomic_cmpxchg_i32(TCGv_i32 retv, TCGv addr, TCGv_i32 cmpv, > > + TCGv_i32 newv, TCGArg idx, TCGMemOp memop) > > +{ > > + memop = tcg_canonicalize_memop(memop, 0, 0); > > + > > + if (!parallel_cpus) { > > This breaks the compile because parallel_cpus isn't visible to the > function. However I suspect it's because there is a missing patch in > this series (I checked my email and the archive). What happened to 06/35?
It doesn't break the build for me--but I'm grabbing the series from github. I think 06/35 was meant to be this patch: https://github.com/rth7680/qemu/commit/fab3abe9220 The whole series is here: https://github.com/rth7680/qemu/tree/atomic-4 Emilio