[Qemu-devel] Re: [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen

[Stefano Stabellini]

On Mon, 23 Aug 2010, Juan Quintela wrote:
> > +    register_savevm(NULL, "gpe", 0, 1, gpe_save, gpe_load, s);
> 
> Please port this to VMSTATE.
> 
> If possible (i.e. not problems with backwards compatibility), something like:
> 
> > +    for ( i = 0; i < ACPI_GPE0_BLK_LEN / 2; i++ ) {
> > +        qemu_get_8s(f, &s->gpe0_sts[i]);
> > +    }
> > +    for ( i = 0; i < ACPI_GPE0_BLK_LEN / 2; i++ ) {
> > +        qemu_get_8s(f, &s->gpe0_en[i]);
> > +    }
> 
> Would be easier to put in vmstate.
> 
 
Ok, will do.