On 24.08.2010, at 00:50, Anthony Liguori wrote: > On 08/23/2010 05:45 PM, Alexander Graf wrote: >>> Device_add already works with this set and only required minor changes the >>> s390 specific code. So that part was pretty slick :). The part that didn't >>> work was the drive_add one. >>> >>> What is blockdev_add supposed to be? drive_add without IF_SCSI? > > drive_add without if= and without the PCI-isms. > >>> To be a bit more precise on how things work with this set: >>> >>> (qemu) drive_add 0 id=my_disk,if=none,file=/dev/null >>> OK >>> > > In theory, something like: > > (qemu) blockdev_add id=my_disk,file=/dev/null
So why add yet another command when we could use the existing drive_add? Wouldn't it make more sense to deprecate if=!none, move forward from there, make if=none the default and around 0.16 or so drop if= from drive_add? Alex
