On Thu, Oct 06, 2016 at 06:00:52PM +0200, Radim Krčmář wrote: > 2016-10-06 11:51-0300, Eduardo Habkost: > > On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote: > >> Signed-off-by: Radim Krčmář <rkrc...@redhat.com> > >> --- > >> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > >> @@ -2015,6 +2015,7 @@ static Property vtd_properties[] = { > >> DEFINE_PROP_UINT32("version", IntelIOMMUState, version, 0), > >> DEFINE_PROP_ON_OFF_AUTO("eim", IntelIOMMUState, intr_eim, > >> ON_OFF_AUTO_AUTO), > >> + DEFINE_PROP_BOOL("buggy_eim", IntelIOMMUState, buggy_eim, false), > > > > I suggest "buggy-eim", to follow the usual style for QOM property > > names. > > > > Assuming the name gets changed: > > > > Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > > I'll change the name to "x-buggy-eim" and also squash the patch with > [6/8] as the property doesn't seem to be hated too much. > > It's going to be a different patch, so I'll drop the r-b by default, > sorry.
You don't have to drop the r-b if the change is mechanical or minor. Anyway, waiting for the next version. -- MST