>>> Eric Blake <ebl...@redhat.com> 2016/9/27 星期二 上午 4:17 >>>
>On 09/26/2016 05:38 AM, Daniel P. Berrange wrote:
>> On Mon, Sep 26, 2016 at 06:16:26PM +0800, Lin Ma wrote:
>>> Automatically generate enum value strings that containing the acceptable
>>> values.
>>> (Borrowwed Daniel's code.)
>
>s/Borrowwed/Borrowed/
Sorry for the late reply, I was on vacation.
Thanks for the review.
>
>>>
>>> Signed-off-by: Lin Ma <l...@suse.com>
>>> ---
>>> scripts/qapi-types.py | 2 ++
>>> scripts/qapi.py | 9 +++++++++
>>> 2 files changed, 11 insertions(+)
>>
>> This will need some test case coverage in tests/ somewhere, but I'm
>> not sure exactly which place is best - Eric/Markus can probably advise
>
>tests/test-qmp-commands.c is the first one that comes to mind, for
>adding another test case to an existing program.
>
I'm not familiar with how to write qapi generator code and related test
code at all. I'll start to dig, Any guidance is appreciated.
For adding test case, Only this tests/test-qmp-commands.c needs to be
modified, right?
Thanks,
Lin
