----- Original Message -----
> From: "David Hildenbrand" <d...@daveh.de>
> To: "Claudio Imbrenda" <imbre...@linux.vnet.ibm.com>
> Cc: "David Hildenbrand" <d...@daveh.de>, "Paolo Bonzini"
> <pbonz...@redhat.com>, qemu-devel@nongnu.org
> Sent: Wednesday, October 12, 2016 8:38:15 PM
> Subject: Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour
>
> On Wed, Oct 12, 2016 at 03:55:18PM +0200, Claudio Imbrenda wrote:
> > On 12/10/16 15:15, David Hildenbrand wrote:
> > >>> + for (cx = 0; ccpus && ccpus[cx]; cx++) {
> > >>> + cpu_single_step(cpu, 0);
> > >
> > > This looks suspicious
> >
> > why? we set all cpus to single step, since that is the default, and then
> > we clear the single-step property from all CPUs that should be restarted
> > in normal mode, then we restart all CPUs. Those in single-step will
> > indeed only perform one single step, the others will run freely (at
> > least until the first single-step CPU stops again).
>
> actually I was more concerned about calling it on "cpu" in a loop.
And we all missed that it should have been ccpus[cx], not cpu. :)
Paolo
