On Thu, Oct 13, 2016 at 07:36:07PM +0100, Peter Maydell wrote: > On 13 October 2016 at 19:29, Stefan Weil <s...@weilnetz.de> wrote: > > scripts/tracetool generates a C preprocessor macro from the name of the > > build directory. Any characters which are possible in a directory name > > but not allowed in a macro name must be substituted, otherwise builds > > will fail. > > > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > > --- > > > > I had problems with a build directory of the form "host,variant". > > Is this fix needed for stable, too? > > Why does it need to care about the build directory name at all? > Ideally builds should be entirely deterministically reproducible > whatever the path to the source or build directory names is...
It's trying to construct the relative path from the source directory to a trace-events file (inside the source directory). This is used so that block/trace-event macros have BLOCK in their name while net/trace-events have NET, etc. It does not care about the build directory or source directory path per se. Therefore deterministic builds shouldn't be a problem if the code is working correctly ;). Stefan
signature.asc
Description: PGP signature
