On Mon, 10 Oct 2016 13:53:37 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote:
> Make virtio_device_start_ioeventfd_impl use the same logic as > dataplane to set up the host notifier. This removes the need > for the set_handler argument in set_host_notifier_internal. > > This is a first step towards using virtio_bus_set_host_notifier > as the sole entry point to set up ioeventfds. At least now > the functions have the same interface, but they still differ > in that virtio_bus_set_host_notifier sets ioeventfd_disabled. > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > hw/virtio/virtio-bus.c | 12 +++--------- > hw/virtio/virtio.c | 16 +++++++++++++--- > include/hw/virtio/virtio-bus.h | 2 +- > 3 files changed, 17 insertions(+), 13 deletions(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 93eec83..2817d42 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -2100,11 +2100,21 @@ static int > virtio_device_start_ioeventfd_impl(VirtIODevice *vdev) > if (!virtio_queue_get_num(vdev, n)) { > continue; > } > - r = set_host_notifier_internal(proxy, qbus, n, true, true); > + r = set_host_notifier_internal(proxy, qbus, n, true); > if (r < 0) { > err = r; > goto assign_error; > } > + virtio_queue_set_host_notifier_fd_handler(&vdev->vq[n], true, true); > + } > + > + for (n = 0; n < VIRTIO_QUEUE_MAX; n++) { > + /* Kick right away to begin processing requests already in vring */ > + VirtQueue *vq = &vdev->vq[n];; Extra ';' > + if (!vq->vring.num) { > + continue; > + } > + event_notifier_set(&vq->host_notifier); > } > return 0; > Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>