[Qemu-devel] Re: [PATCH 12/14] size_t is unsigned, so (foo >= 0) is always true

[Anthony Liguori]

On 08/30/2010 10:35 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen<jes.soren...@redhat.com>
Signed-off-by: Jes Sorensen<jes.soren...@redhat.com>
   

This is the wrong fix, bytes should be a ssize_t or an int because 
tight_compress_data can return error.

Regards,

Anthony Liguori

---
  ui/vnc-enc-tight.c |    8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index c4c9c3b..df975af 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -926,7 +926,7 @@ static int send_full_color_rect(VncState *vs, int x, int y, 
int w, int h)
                                  
tight_conf[vs->tight.compression].raw_zlib_level,
                                  Z_DEFAULT_STRATEGY);

-    return (bytes>= 0);
+    return 1;
  }

  static int send_solid_rect(VncState *vs)
@@ -1001,7 +1001,7 @@ static int send_mono_rect(VncState *vs, int x, int y,
      vs->tight.tight.offset = bytes;

      bytes = tight_compress_data(vs, stream, bytes, level, Z_DEFAULT_STRATEGY);
-    return (bytes>= 0);
+    return 1;
  }

  struct palette_cb_priv {
@@ -1057,7 +1057,7 @@ static bool send_gradient_rect(VncState *vs, int x, int 
y, int w, int h)

      bytes = tight_compress_data(vs, stream, bytes,
                                  level, Z_FILTERED);
-    return (bytes>= 0);
+    return 1;
  }

  static int send_palette_rect(VncState *vs, int x, int y,
@@ -1118,7 +1118,7 @@ static int send_palette_rect(VncState *vs, int x, int y,

      bytes = tight_compress_data(vs, stream, bytes,
                                  level, Z_DEFAULT_STRATEGY);
-    return (bytes>= 0);
+    return 1;
  }

  #if defined(CONFIG_VNC_JPEG) || defined(CONFIG_VNC_PNG)