On 08/30/2010 06:15 PM, Anthony Liguori wrote:
On 08/30/2010 10:42 AM, Paolo Bonzini wrote:
On 08/30/2010 05:35 PM, jes.soren...@redhat.com wrote:
- JSONParsingState state = {};
+ JSONParsingState state;
+ memset(&state, 0, sizeof(state));
state.ap = ap;
JSONParsingState state = { .ap = ap };
achieves the same.
But the fundamental is, what problem does GCC have with the original? If
there isn't a reasonable answer, then I'm inclined to think this warning
mode is a waste of time.
It falls under the "missing fields in initializer" warning. Arguably,
an empty initializer should be special cased, but it isn't.
I agree that Jes's original patch is ugly, but the C99 initializer is an
improvement.
Paolo
