On 08/30/2010 11:27 AM, Anthony Liguori wrote: > On 08/30/2010 01:19 PM, Jes Sorensen wrote: >> >> I totally agree on this. The problem with having such arguments >> passed in is that you never know if they were used in the past and >> it was forgotten when the code using them was removed, or if it's >> new code, in which case they do deserve the extra scrutiny. >> > > Or, we exercise common sense instead of blinding removing arguments > just because a certain uncommon warning mode of GCC complains.
If you make a reasoned decision to keep the argument, then annotate it with #define UNUSED __attribute__((unused)) and the warning will go away. As to whether the argument should be retained in these specific cases, I am agnostic. r~
