On Fri, 28 Oct 2016 14:11:38 +0200 Gerd Hoffmann <kra...@redhat.com> wrote:
> From: Samuel Thibault <samuel.thiba...@ens-lyon.org> > > Use ncursesw package instead of curses on non-mingw, and check a few > functions. > Also take cflags from pkg-config, since cursesw headers may be in a > separate, non-default directory. > > Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > Message-id: 20161015195308.20473-3-samuel.thiba...@ens-lyon.org > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > configure | 29 ++++++++++++++++++++--------- > 1 file changed, 20 insertions(+), 9 deletions(-) This seems to break configure on one of the systems I use (which may or may not have a broken setup). SLES12SP1 (s390x) without curses in the output of pkg-config --list-all, but headers seem to be present (? -- I'm not the admin). Other systems (Fedora and Ubuntu) are fine. Before this commit, configure detected curses=yes and all seemed well. Now, configure barfs about -Werror. Some snippets from config.log: # QEMU configure log Mon Oct 31 12:35:26 CET 2016 # Configured with: '/home/cohuck/git/qemu/build/../configure' '--target-list=s39 0x-softmmu s390x-linux-user' '--enable-kvm' '--enable-vhost-net' '--enable-linux -aio' cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-protot ypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-s trict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty -body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qual ifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-prot ector-all -I/usr/include/libpng16 -o config-temp/qemu-conf.exe config-temp/qemu- conf.c -m64 -g config-temp/qemu-conf.c: In function ‘main’: config-temp/qemu-conf.c:9:3: warning: implicit declaration of function ‘addwstr’ [-Wimplicit-function-declaration] addwstr(L"wide chars\n"); ^ config-temp/qemu-conf.c:9:3: warning: nested extern declaration of ‘addwstr’ [-Wnested-externs] config-temp/qemu-conf.c:10:3: warning: implicit declaration of function ‘addnwstr’ [-Wimplicit-function-declaration] addnwstr(&wch, 1); ^ config-temp/qemu-conf.c:10:3: warning: nested extern declaration of ‘addnwstr’ [-Wnested-externs] /tmp/ccgsfoYo.o: In function `main': /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:5: undefined reference to `curses_version' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:8: undefined reference to `resize_term' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:9: undefined reference to `addwstr' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:10: undefined reference to `addnwstr' collect2: error: ld returned 1 exit status cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw config-temp/qemu-conf.c: In function ‘main’: config-temp/qemu-conf.c:9:3: warning: implicit declaration of function ‘addwstr’ [-Wimplicit-function-declaration] addwstr(L"wide chars\n"); ^ config-temp/qemu-conf.c:9:3: warning: nested extern declaration of ‘addwstr’ [-Wnested-externs] config-temp/qemu-conf.c:10:3: warning: implicit declaration of function ‘addnwstr’ [-Wimplicit-function-declaration] addnwstr(&wch, 1); ^ config-temp/qemu-conf.c:10:3: warning: nested extern declaration of ‘addnwstr’ [-Wnested-externs] /tmp/ccgsfoYo.o: In function `main': /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:5: undefined reference to `curses_version' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:8: undefined reference to `resize_term' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:9: undefined reference to `addwstr' /home/cohuck/git/qemu/build/config-temp/qemu-conf.c:10: undefined reference to `addnwstr' collect2: error: ld returned 1 exit status cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw config-temp/qemu-conf.c: In function ‘main’: config-temp/qemu-conf.c:9:3: warning: implicit declaration of function ‘addwstr’ [-Wimplicit-function-declaration] addwstr(L"wide chars\n"); ^ config-temp/qemu-conf.c:9:3: warning: nested extern declaration of ‘addwstr’ [-Wnested-externs] config-temp/qemu-conf.c:10:3: warning: implicit declaration of function ‘addnwstr’ [-Wimplicit-function-declaration] addnwstr(&wch, 1); ^ config-temp/qemu-conf.c:10:3: warning: nested extern declaration of ‘addnwstr’ [-Wnested-externs] cc -Werror -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g -lncursesw config-temp/qemu-conf.c: In function ‘main’: config-temp/qemu-conf.c:9:3: error: implicit declaration of function ‘addwstr’ [-Werror=implicit-function-declaration] addwstr(L"wide chars\n"); ^ config-temp/qemu-conf.c:9:3: error: nested extern declaration of ‘addwstr’ [-Werror=nested-externs] config-temp/qemu-conf.c:10:3: error: implicit declaration of function ‘addnwstr’ [-Werror=implicit-function-declaration] addnwstr(&wch, 1); ^ config-temp/qemu-conf.c:10:3: error: nested extern declaration of ‘addnwstr’ [-Werror=nested-externs] cc1: all warnings being treated as errors As said, I'm not sure whether this system has a sane setup, and I'm just a user there. Just noticed this new breakage (which goes away with --disable-curses).
