ping I would like to do further work based on this, and Dave's review for v1 was quite favorable (IMHO). Any chance of this getting merged soon (or receiving critical comments so I can move forward)?
Cheers, Halil On 10/20/2016 03:25 PM, Halil Pasic wrote: > The member VMStateField.start was solely used to implement the partial > data migration for VBUFFER data (basically provide migration for a > sub-buffer). However the implementation of this feature is broken, but > this goes unnoticed since the feature is not used at all. > > Let us add an unit test for VBUFFER and then remove the useless > VMStateFiled.start. > > An additional benefit is that .start can be re introduced to be used for > linked structures as proposed by Jianjun in "[QEMU PATCH v6 2/2] > migration: migrate QTAILQ". > > Guenther Hutzl (1): > tests/test-vmstate.c: add vBuffer test > > Halil Pasic (1): > migration: drop unused VMStateField.start > > hw/char/exynos4210_uart.c | 2 +- > hw/display/g364fb.c | 2 +- > hw/dma/pl330.c | 8 ++-- > hw/intc/exynos4210_gic.c | 2 +- > hw/ipmi/isa_ipmi_bt.c | 4 +- > hw/ipmi/isa_ipmi_kcs.c | 4 +- > hw/net/vmxnet3.c | 2 +- > hw/nvram/mac_nvram.c | 2 +- > hw/nvram/spapr_nvram.c | 2 +- > hw/sd/sdhci.c | 2 +- > hw/timer/m48t59.c | 2 +- > include/migration/vmstate.h | 20 +++----- > migration/savevm.c | 2 +- > migration/vmstate.c | 4 +- > target-s390x/machine.c | 2 +- > tests/test-vmstate.c | 114 > ++++++++++++++++++++++++++++++++++++++++++++ > util/fifo8.c | 2 +- > 17 files changed, 141 insertions(+), 35 deletions(-) >
