Hi, On 2016-11-14 17:33, Jin Guojie wrote: > Richard, > > I have studied your V2 patch > > https://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg02969.html > > . Though I have not tested this patch on Loongson machine, I feel this > patch has implemented MIPS64 ISA very completely, including big/little > endian, N32 and N64 ABI. The use of #if is more clean. Many corner cases > are well handled. My patch is only a subset of yours. > > I wonder why your patch have not be merged into the mainstream. > If I had seen it before, I don't need to waste time reinventing my patch. > > Since tcg target for MIPS64 is of great use for developers, I > really hope this feature can be merged into mainstream. > > Is your v2 patch still in review process? Is there chance for this > patch to be merged in a not so long term? Or should other code > work should be done before being merged?
Please see: https://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg06444.html In short this patch set looks overall good, but breaks support for existing big-endian 32-bit hosts. It also doesn't fully work on 64-bit hosts for 32-bit guests, but I guess that's something acceptable, as it's not a regression. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net