❦ 17 novembre 2016 07:27 -0800, no-re...@patchew.org : > === OUTPUT BEGIN === > Checking PATCH 1/1: tftp: fake support for netascii protocol... > ERROR: suspect code indent for conditional statements (2, 6) > #24: FILE: slirp/tftp.c:329: > + if (strcasecmp(&tp->x.tp_buf[k], "octet") == 0) { > + k += 6; > > ERROR: suspect code indent for conditional statements (2, 6) > #26: FILE: slirp/tftp.c:331: > + } else if (strcasecmp(&tp->x.tp_buf[k], "netascii") == 0) { > + k += 9;
Indentation is consistent with what the remaining of the file. > ERROR: Missing Signed-off-by: line(s) Should I resend the patch for that or the amendment I sent in another mail is sufficient? -- Vincent Bernat — vincent.ber...@exoscale.ch ❬❱ https://www.exoscale.ch