On Fri, Nov 18, 2016 at 11:36:56AM +0100, Laszlo Ersek wrote: > This is v3 of the series, with updates based on the v2 discussion: > <http://lists.nongnu.org/archive/html/qemu-devel/2016-11/msg02687.html>. > > I've added feature negotiation via the APM_STS ("scratchpad") register. > A new spec file called "docs/specs/q35-apm-sts.txt" is included. > > Tested with new OVMF patches (about to send out those as well). > Regression tested with SeaBIOS (beyond simple functional tests with > maximum SeaBIOS logging enabled, I used gdb to step through the new > ich9_apm_status_changed() callback to see if it was behaving compatibly > with SeaBIOS). > > The series was developed and tested on top of v2.7.0, because v2.8.0-rc0 > crashes very quickly for me when running OVMF: > > kvm_io_ioeventfd_add: error adding ioeventfd: File exists > > It is my understanding that there are patches on the list for this: > > [Qemu-devel] [PATCH v2 for-2.8 0/3] virtio fixes > > Anyway, the series rebases to v2.8.0-rc0 without as much as context > differences. > > Cc: "Kevin O'Connor" <ke...@koconnor.net> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Paolo Bonzini <pbonz...@redhat.com>
I'll review. Pls remember it will have to be re-posted or pinged after 2.8 is out. > Thanks > Laszlo > > Laszlo Ersek (3): > hw/isa/apm: introduce callback for APM_STS_IOPORT writes > hw/isa/lpc_ich9: add SMI feature negotiation via APM_STS > hw/isa/lpc_ich9: ICH9_APM_STS_F_BROADCAST_SMI: inject SMI on all VCPUs > > docs/specs/q35-apm-sts.txt | 80 > ++++++++++++++++++++++++++++++++++++++++++++++ > include/hw/i386/ich9.h | 9 ++++++ > include/hw/isa/apm.h | 9 +++--- > hw/acpi/piix4.c | 2 +- > hw/isa/apm.c | 15 ++++++--- > hw/isa/lpc_ich9.c | 64 +++++++++++++++++++++++++++++++++++-- > hw/isa/vt82c686.c | 2 +- > 7 files changed, 168 insertions(+), 13 deletions(-) > create mode 100644 docs/specs/q35-apm-sts.txt > > -- > 2.9.2