Re: [Qemu-devel] [PATCH v2 4/5] target-m68k: Implement bitfield ops for registers

[Richard Henderson]

On 11/27/2016 11:46 AM, Laurent Vivier wrote:
>> +            uint32_t maski = -2U << (len - 1);
>> > +            uint32_t roti = (ofs + len) & 31;
>> > +            tcg_gen_andi_i32(tmp, src, maski);
> should be:
> 
>                tcg_gen_andi_i32(tmp, src, ~maski);
> 
> Is it correct?

Yes.


r~