On Tue, Nov 29, 2016 at 04:56:55PM +0800, Li Qiang wrote: > Hi > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones <rjo...@redhat.com>: > > > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > > > From: Li Qiang <liqiang...@360.cn> > > > > > > When the Intel 6300ESB watchdog is hot unplug. The timer allocated > > > in realize isn't freed thus leaking memory leak. This patch avoid > > > this through adding the exit function. > > > > I will just note that the real hardware is not hot-pluggable. However > > we don't need to stick to the real hardware capabilities, so that's OK. > > > > > > If the hardware is not hot-pluggable, we can set dc->hotpluggable = false.
No no no! The hardware hasn't been made for a decade or two, we don't need to stick with what the real hardware did. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
