On 11/30/2016 04:08 AM, Laszlo Ersek wrote: > Recent git releases support the diff.orderFile permanent setting. (In > older releases, the -O option had to be specified on the command line, > or in aliases, for the same effect, which was quite inconvenient.) From > git-diff(1): > > -O<orderfile> > Output the patch in the order specified in the <orderfile>, > which has one shell glob pattern per line. This overrides > the diff.orderFile configuration variable (see git- > config(1)). To cancel diff.orderFile, use -O/dev/null. > > In my experience, an order file such as: > > configure > *Makefile* > *.json > *.txt > *.h > *.c > > that is, a priority order that goes from > descriptive/declarative/abstract to imperative/specific works wonders > for reviewing.
I've been doing this for some time now, although I sometimes tweak the order on a per-series basis to highlight what I think is most interesting in that series. My current order file contents are: qapi-schema*.json qapi/*.json include/qapi/visitor.h include/qapi/visitor-impl.h scripts/qapi.py scripts/*.py *.h qapi/qapi-visit-core.c *.c stemming from a patch series that touched visitor interfaces. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature