On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > > types because the internal virtio-pci.disable-modern=on compat property > > always prevail. > > > > This should ideally be fixed in the qdev properties core code, but it is > > too late in the QEMU 2.8 schedule. So this patch fixes the issue by setting > > the compat properties for every virtio-*-pci subtypes instead of the base > > virtio-pci type. > > > > Signed-off-by: Greg Kurz <gr...@kaod.org> > > What's the rush? Either the issue is or isn't 2.8 material. If it is, > let's fix it in qdev core now. If it isn't no need for quick fixes, > just wait a bit and merge qdev core fix after 2.8 is out.
Because it is a regression, and changing HW_COMPAT_* is less risky than changing qdev core rules about -global ordering. -- Eduardo
