On Fri, Dec 30, 2016 at 04:19:31PM +0800, Jason Wang wrote: > > > On 2016年12月16日 11:53, Jason Wang wrote: > > > > > >On 2016年12月16日 10:53, Peter Xu wrote: > >>On Mon, Nov 07, 2016 at 03:09:47PM +0800, Jason Wang wrote: > >>>To avoid duplicated name and ease debugging. > >>> > >>>Cc: Michael S. Tsirkin <m...@redhat.com> > >>>Cc: Paolo Bonzini <pbonz...@redhat.com> > >>>Cc: Richard Henderson <r...@twiddle.net> > >>>Cc: Eduardo Habkost <ehabk...@redhat.com> > >>>Acked-by: Peter Xu <pet...@redhat.com> > >>>Signed-off-by: Jason Wang <jasow...@redhat.com> > >>>--- > >>> hw/i386/intel_iommu.c | 4 +++- > >>> 1 file changed, 3 insertions(+), 1 deletion(-) > >>> > >>>diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > >>>index 1655a65..5272c30 100644 > >>>--- a/hw/i386/intel_iommu.c > >>>+++ b/hw/i386/intel_iommu.c > >>>@@ -2323,6 +2323,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState > >>>*s, PCIBus *bus, int devfn) > >>> uintptr_t key = (uintptr_t)bus; > >>> VTDBus *vtd_bus = g_hash_table_lookup(s->vtd_as_by_busptr, &key); > >>> VTDAddressSpace *vtd_dev_as; > >>>+ char name[128]; > >>> if (!vtd_bus) { > >>> /* No corresponding free() */ > >>>@@ -2336,6 +2337,7 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState > >>>*s, PCIBus *bus, int devfn) > >>> vtd_dev_as = vtd_bus->dev_as[devfn]; > >>> if (!vtd_dev_as) { > >>>+ snprintf(name, sizeof(name), "intel_iommu_devfn_%d", devfn); > >>Better with bus number as well? ;) > >> > >>Like: "%02x:%02x.%x" for (bus, dev, fn). > >> > >>Thanks, > >> > >>-- peterx > > > >Yes, will do it in next version. > > > >Thanks > > > > Actually, I choose not to bother since bus and fn number needs more codes to > get.
Should this work? snprintf(name, sizeof(name), "intel_iommu_%02x:%02x.%x", pci_bus_num(bus), VTD_PCI_SLOT(devfn), VTD_PCI_FUNC(devfn)); Anyway, I am okay as well to keep it as it is. :) -- peterx