On Sat, Dec 31, 2016 at 09:18:27AM +0800, xiaoqiang zhao wrote: > This is some QOM'ify work relate with ppc. > See each commit message for details. > > xiaoqiang zhao (4): > hw/gpio: QOM'ify mpc8xxx.c > hw/ppc: QOM'ify e500.c > hw/ppc: QOM'ify ppce500_spin.c > hw/ppc: QOM'ify spapr_vio.c > > hw/gpio/mpc8xxx.c | 20 +++++++++++--------- > hw/ppc/e500.c | 17 ++++------------- > hw/ppc/ppce500_spin.c | 18 ++++++++---------- > hw/ppc/spapr_vio.c | 2 -- > 4 files changed, 23 insertions(+), 34 deletions(-)
Patches 1-3 all have the same problem - they move memory region
initialization and similar to an instance_init function. This is not
how things are generally done in the qdev model. Instead that phase
of initialization should be done from a dc->realize() function.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
