On Wed, Sep 15, 2010 at 02:50:01PM +0900, Isaku Yamahata wrote: > On Wed, Sep 08, 2010 at 01:31:22PM +0300, Michael S. Tsirkin wrote: > > > + > > > +static void pcie_notify(PCIDevice *dev, uint16_t vector, > > > + bool trigger, int level) > > > +{ > > > + /* masking/masking interrupt is handled by upper layer. > > > + * i.e. msix_notify() for MSI-X > > > + * msi_notify() for MSI > > > + * pci_set_irq() for INTx > > > + */ > > > > So this will send another interrupt when level is 0? > > Yes. The condition that triggers MSI-X/MSI can be different from > the one that asserts INTx as you can see it in the following code. > trigger and level are set independently.
Looks like a bug ... but we are better off splitting this to assert/deassert case as I suggested separately, anyway. > -- > yamahata