On 09/01/2017 20:42, Peter Maydell wrote: >> + case VERIFY_10: >> + case VERIFY_12: >> + case VERIFY_16: >> + /* We get here only for BYTCHK == 0x01 and only for scsi-block. >> + * As far as DMA is concerned, we can treat it the same as a write; >> + * scsi_block_do_sgio will send VERIFY commands. >> + */ >> if (r->req.cmd.buf[1] & 0xe0) { >> goto illegal_request; >> } > Coverity now complains about the fallthrough into the case statements > added here. I assume from the patch that the fallthrough is deliberate, > in which case a /* fall through */ comment would assist future > readers...
Indeed---I thought I had waived that already in the scan dashboard. Paolo