On 01/10/2017 05:45 AM, Michael S. Tsirkin wrote: > On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: >> v7 changelog: >> 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >> please take a look, there is detailed description in the patch. >> 2. add the R-b from Hannes Reinecke >> >> Test: >> 1. make check: pass >> 2. After applied all the patch, command line test for all the >> affected devices, just make sure device realize process is ok, >> no crash, but no further use of device. > > Consider the megasas device for example, don't you > need to test that the change actually does what > it's intended to do? >
Thanks very much for your reminding, it does has a problem in patch "megasas: remove unnecessary megasas_use_msix()", it is only one screw megasas. Sorry for that. Install linux distro to test megasas as following: ./qemu-system-x86_64 --enable-kvm -m 1024 -device megasas,id=scsi0,bus=pci.0 -drive file=/xx/xx/scsi-disk.img,if=none,id=drive-scsi0 -device scsi-disk,bus=scsi0.0,channel=0,scsi-id=4,lun=0,drive=drive-scsi0,id=scsi0-4 -cdrom /xx/vm/Fedora-Server-DVD-x86_64-23.iso [-boot once=d] --monitor stdio Sincerely, Cao jin
